-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send email via Parse.Cloud.sendEmail #7096
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7096 +/- ##
==========================================
+ Coverage 93.63% 93.65% +0.02%
==========================================
Files 169 169
Lines 12500 12508 +8
==========================================
+ Hits 11704 11714 +10
+ Misses 796 794 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks all good in this PR!
Could you just open a PR for the Cloud Code docs and add a small section for sending mail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a renaming; apologies I didn't come across that earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, thanks for this PR!
I’ve just realised the change log says sendMail not sendEmail |
* initial * more tests * Update CHANGELOG.md * review * log on error * change logger to error * rename * Update Parse.Cloud.js
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
Related issue: #7089
Approach
Helper function to send emails via attached mailAdapter. Usage:
Parse.Cloud.sendMail(data)
Mail data is dependent on the mail adapter.
TODOs before merging